After upgrade git lfs push ends up in Call to undefined method on Diffusion Git LFS Authenticate Workflow

Observed Behavior:
After upgrading Phabricator on master tree and stable, git push with GIT LFS tracked files and git clone is not longer working.

git push
Git LFS: (0 of 1 files) 0 B / 4.71 MB
batch request: PHP Fatal error: Call to undefined method DiffusionGitLFSAuthenticateWorkflow::getUser() in /var/www/html/phabricator/src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php on line 87: exit status 255
error: failed to push some refs to ‘ssh://vcs@server.mydomein.net/diffusion/1/gitlfstest.git’

Expected Behavior:
Phabricators diffusion should upload files tracked by git lfs on the file storage and create a reference file for the binary in the git repository.

Phabricator Version:
phabricator 1e3d1271ada02ee80693901286152422d6e9d731 (Wed, Jan 31)
arcanist 2e02332216c692e9bcedfa95d30602173050d7ca (Tue, Jan 16)
phutil 2d8cdda8cc4c12600099ccdf0c6cb84b468691e1 (Thu, Jan 18)
diff 3.3 at /usr/bin/diff
git 1.8.3.1 at /usr/bin/git
hg Not Available
pygmentize Not Available
svn Not Available

Because i setup a test server from scratch hg, pygmentize and svn not installed

git lfs version git-lfs/2.3.4 (GitHub; linux amd64; go 1.8.5)

Reproduction Steps:

You need the latest phabricator version on master or stable tree.
Configure diffusion for using ssh and git.
Activate git lfs (./bin/config set diffusion.allow-git-lfs true)
Restart apache and phd daemons
Create a new repository.
Clone it. Track lfs files, push it.

git clone ssh://vcs@server.mydomein.net/diffusion/1/gitlfstest.git
cd gitlfstest
git lfs track "*.xpi"
git add .gitattributes
git commit -m "test"
git push

until this step everything works like expected!

cp ../Downloads/lightning-5.4-sm+tb-linux.xpi .
git add lightning-5.4-sm+tb-linux.xpi
git commit -m "test"
git push
Remote "origin" does not support the LFS locking API. Consider disabling it with:
  $ git config lfs.https://server.mydomein.net/diffusion/1/gitlfstest.git/info/lfs.locksverify false
Git LFS: (0 of 1 files) 0 B / 4.71 MB                                                                                
batch request: PHP Fatal error:  Call to undefined method DiffusionGitLFSAuthenticateWorkflow::getUser() in /var/www/html/phabricator/src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php on line 87: exit status 255
error: failed to push some refs to 'ssh://vcs@server.mydomein.net/diffusion/1/gitlfstest.git'

Don’t know if the locking API is neccessary but … deactivating does not help.

git config lfs.https://server.mydomein.net/diffusion/1/gitlfstest.git/info/lfs.locksverify false
git push
Git LFS: (0 of 1 files) 0 B / 4.71 MB                                                                                
batch request: PHP Fatal error:  Call to undefined method DiffusionGitLFSAuthenticateWorkflow::getUser() in /var/www/html/phabricator/src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php on line 87: exit status 255
error: failed to push some refs to 'ssh://vcs@server.mydomein.net/diffusion/1/gitlfstest.git'

Apache Log Level is on Debug and i only get no message
Even PHP is set to E_ALL for Logging.

I started these phd daemons with debugging
./bin/phd debug PhabricatorRepositoryPullLocalDaemon
./bin/phd debug PhabricatorTriggerDaemon
./bin/phd debug PhabricatorTaskmasterDaemon

After that i only got these too lines…

[30-Jan-2018 13:54:49 UTC]   #9 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:131]
[30-Jan-2018 13:56:42 UTC] 2018-01-30 1:56:42 PM [SGNL] Overseer ("37858") received signal 2 ("SIGINT")

I hope it is not my fault by forgetting some configuration settings. If it is a bug i’m here and will test everything for you to figure it out quickly.

Thanks in advance!
Marco Weiß

Thanks, see https://secure.phabricator.com/D18977.

Thanks a lot for that quick fix!
I pulled the newest master and changed this one line manually to test immediately and it works now!

Thank you again for this amazing support!
Marco Weiß