We use Phab and Arc. We want to make sure that all revisions are approved before being landed. Normally, this works. Eg, if I make an arc diff and then try to arc land it immediately, it fails because the diff hasn’t been approved in Phab.
However, one of my coworkers discovered a corner case:
- Submit a revision (arc diff)
- Have someone accept the revision in the Phab UI
- Commit another change locally. DO NOT run arc diff to update Phab.
- Run arc land.
Now, the changes that were committed locally get landed even though they were never approved (indeed, Phab never even know about the changes at all).
I assume that there’s some config flag we just need to set, but I can’t find any documentation about it.