Bug in notification server aphlict


#2

What are the steps for us to reproduce this locally? I imagine this bug report requires a specific version of Node to reproduce.


#3

We use node v6.10.3 but the Error is not coming from node.
The error comes from an API change in the WebSockets Library.
Starting version 3.0.0 it changed the function parameter of the ‘connect’ event.
See this pull request on github: https://github.com/websockets/ws/pull/1099

To reproduce it just use a fresh install, I did nothing special.


#4

Sorry, yes I meant ws. See https://secure.phabricator.com/T12755 for the full bug report. Any fix we’d have to ensure older versions still work.


#5

I can send you an invite to secure as well here shortly


#6

There could be an easy solution just checking for object existence.
Thank you :slight_smile:


#7

If you want to contribute a fix, let me know. Essentially, needs to work on both 2.x and 3.x, be tested on both, and you’ll have to sign up for secure, sign a CLA, upload a diff. If not let me know and I’ll take it from here.


#8

Yes, I’d like to sign up for secure, but I can’t proceed with sign-up. No
type of registration works.
I will create a fix then.

Chad phabricator@discoursemail.com schrieb am Do., 27. Juli 2017, 21:12:


#9

I sent you an invite email a few hours ago. I assume that lets you register or no?


#10

No it doesn’t work.
I have appended a screenshot.

Chad phabricator@discoursemail.com schrieb am Do., 27. Juli 2017, 22:27:


#11

So it seems, I’ve asked Evan if I’ve mis-configured something.


#12

Sorry this site/system is all new and we’re still working out the kinks.


#13

OK I’ve turned on registration for user/pass so you can sign up.


#14

This is resolved in https://secure.phabricator.com/rP3b14c1fdd1cf500ad42a095780edb176826d3788


#15

@chad01 This issue is not resolved for me.

My version of phabricator came with the fix on this page:
https://secure.phabricator.com/rP3b14c1fdd1cf500ad42a095780edb176826d3788

What I mean is that my code reads like this (and has since install):

95       // This function checks for upgradeReq which is only available in
96       // ws2 by default, not ws3. See T12755 for more information.
97       wss.on('connection', function(ws, request) {
98         if ('upgradeReq' in ws) {
99           request = ws.upgradeReq;
100         }

But I do not get realtime updates in a chatroom. Also, if there user is in another place in Phabricator and someone sends a message to a chat room that he users then the chat-bubble icon does not update, until the user clicks to another page.

So it seems like a websockets problem.

I have installed ws 2.X also and there was no change after restarting Aphlict. Then I reinstalled with ws 3.3.3 and still no change.

Notification Servers seem to be set up correctly.

The Conpherence window says “Setting Up Client” in the bottom of Chromium and “Disconnected” in Firefox.

What should I try?


#16

@chad01 Is there a way you can turn on signups for https://secure.phabricator.com/ ? I don’t see any way to create a new account with email and password.


#17

@securesystemdesign, please read Guide: Reporting a Bug.


#18

I thought I had done that, since I was adding onto an existing bug report. But if you disagree then I will resubmit.


#19

yes, this bug report was closed. You’re probably seeing something else. We need all the information in that document to understand what you’re seeing.


#20

I understand wanting bug reports to be well written but you’ve spent more time policing the form than it should have taken to resolve the issue. I have since installed OpenProject and our company is not going to use Phabricator since Phabricator is buggy and I would have to jump through hoops to report issues. Instead of having a github issues page, for example.


closed #21