Chinese name creates empty row in tag cloud

Reproduction Instructions

  • Create a user called with a display name (“also known as”) of .
  • Subscribe them to a task among at least four other (non-Chinese) users.
  • Observe in the tag cloud with user names reserves an empty row for no apparent reason underneath the Chinese name.

For a live example, see https://phabricator.wikimedia.org/maniphest/task/edit/129499/.

Phabricator/Arcanist Version

Which browser/OS are you using? This doesn’t immediately reproduce for me in Safari, Chrome, or Firefox on macOS.

Here’s an oddly cropped screenshot for anonymity of the other users from Safari, but you can see a tag immediately below:

Screen Shot 2020-02-23 at 6.06.44 PM

I wasn’t able to get weird behavior in any of Safari, Firefox, or Chrome by changing the browser width, either.

Also, just to clarify, my attempt to reproduce is just "look at /maniphest/task/edit/129499/", I’m not interacting with the field at all. Is that sufficient for you? Or does looking work fine, but there’s a problem on interaction? (i.e., “Subscribe them” means “type into the field”, not “subscribe, then later observe state”?)

Oh, actually, I can sort of reproduce this by changing the browser page zoom level. If I zoom in to the page several times, I get this:

Screen Shot 2020-02-23 at 6.14.27 PM

Are you using the default browser zoom level?

Its specific to Firefox indeed. I can’t reproduce it in Chrome.

However, I’m not zoomed in. This is on Firefox 73 for macOS, at the default zoom level. And if I do zoom out or in, I continue to see the bug at all zoom levels from 50% through to 240%. The bug does not happen at the far smallest zoom level (30%) or far biggest (300%).

Aha! It looks like I was on Firefox 71 locally, where it did not reproduce. I updated and it reproduces for me in Firefox 73.

I’ll see if I can find a reasonable fix for this since I suspect one exists. Sometimes there’s no obvious pathway forward for similar bugs, especially with non-100% zoom levels, but I’d guess this may be fixable by adding or adjusting a property like max-height, even if the root cause is something obscure with the font specification or layout engine.

I filed this upstream as https://secure.phabricator.com/T13495.

I suspect it is now fixed in master by https://secure.phabricator.com/D21026, and that change probably doesn’t break anything else.