Coordinating change: T13578 ("Provide `bin/user approve` to approve an account from the CLI")

Good afternoon!

I have a change ready to go for T13578. I was not able to reproduce the original issue on a test installation. I wrote the code anyway, as I’m using the new workflow right now as part of setting up a small Phabricator installation. My change would introduce a new workflow (bin/user approve --user username) based on the workflow for bin/user enable.

Here’s my question: I have a secure.phabricator.com account from before Discourse. Is upstream interested in this change (I’d assume so, since there’s an upstream task for it)? If so, what is the appropriate way to coordinate? On secure, even though I haven’t done the ancient trials referenced in Diviner? Or here, with .patch files? Either way, no problem.

Thank you!

Is upstream interested in this change (I’d assume so, since there’s an upstream task for it)?

Yep.

If so, what is the appropriate way to coordinate?

Just arc diff it into Differential on secure and add me as a reviewer.

Awesome, thank you for the quick response! I’ve submitted D21587.

(This landed and promoted to stable.)

1 Like