Differential large diff hides changes if no inline comments

Reproduction Instructions

  • Create a large enough revision to trigger the WebUI to emit:
    Large Diff
    This large diff affects 897 files. Files without inline comments have been collapsed.
  • Generate multiple diffs against the revision by iteratively modifying several files. Feel free to add comments, but do NOT create any inline comments on at least one the files being modified.

  • Use the “history” tab of the “Revision Contents” section to select a subset of the diffs to view and click “show diffs”. You should see these two notifications:

    Large Diff
    This large diff affects 897 files. Files without inline comments have been collapsed.

    Showing Only Differences
    This revision modifies 847 more files that are hidden because they were not modified between     selected diffs and they have no inline comments.

Expected: Any files with changes between the selected diffs should be shown.

Observed: Files with changes between the selected diffs, but with no inline comments, remain hidden/collapsed. It’s as if the logic to implement the first notification above is overriding the logic to show the selected diffs. This is wrong; files with diffs should always be shown, regardless of whether there are inline comments or not and regardless of the size of the overall revision.

Phabricator/Arcanist Version
2019.6.21