Diffusion doesn't work in read-only mode


#1

Observed Behavior:
attempting to browse a repository in Diffusion while Phabricator is in read-only mode results in an “Improper Cluster Write” error with the message

Unable to establish a write-mode connection (to application database “phabricator_conduit”) because Phabricator is in read-only mode. Whatever you are trying to do does not function correctly in read-only mode.

Expected Behavior:
You should be able to browse repositories in read-only mode

Phabricator Version:
internal fork based on 2019 Week 8 stable

Reproduction Steps:

  1. set up phabricator with a master and replica database
  2. set the master database to “disabled”: true
  3. attempt to browse a repository