Diffusion.getrecentcommitsbypath fails with 500s error when callsign doesn't exist


#1

Observed Behavior:
diffusion.getrecentcommitsbypath fail with 500 error when non existing callsign is passed:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getCommit() on null

Expected Behavior:
Return more graceful error notifying caller that such callsign/repository does not exist

Phabricator Version:
5a578d011723f46a56eb4d1c657397e923b1ac54 (Aug 18 2017) also reproducible in secure.phabricator.com

Reproduction Steps:
Open conduit: https://secure.phabricator.com/conduit/method/diffusion.getrecentcommitsbypath/
Enter:
callsign: "obviouslynotexisting"
path: "/random"
Click call method


#2

I’m willing to provide patch for review…


#3

Fixed in https://secure.phabricator.com/D19558