Diffusion Java file is seen as binary file

Observed Behavior:
Changes to Java file not shown in diffusion when ANSI encoded. States this is a binary even though it is a Java file. Tried using different text encoding but result is the same. File opens in notepad++ and java file contents is shown

Expected Behavior:
Java file contents and changes should be shown in Diffusion

Phabricator Version:
phabricator 9b93697d52f40753799683ce461fcc02f45d7ef5 (Jun 15 2017)
arcanist c04f141ab0231e593a513356b3832a30f9404627 (Jun 9 2017)
phutil 74a1350416eb2df825c2315d6519bee03f77bee9 (Jun 5 2017)

Reproduction Steps:
Commit changes to a java file that is ANSI encoded.
Go to commit for above in Diffusion.
Diffusion will state it is a binary file and not show file content or changes

Hello,

We’ve had this problem as well, this is what we advise to our users, https://c4science.ch/w/c4science/faq/#this-file-is-binary-blan

Cheers

Hi,

Apologies for my late reply.

We converted the file to utf-8 encoding however it is still show as a binary file in the Phabricator UI.

Any ideas?

Thank you,
Hammad

Greetings,

we have same problem as described in this question. However we can not convert files to other encoding for several reasons (mainly due to compatibility with other tools).

Looks like there was some activity on improving things - https://secure.phabricator.com/T3788, but we can’t see text diff in Diffusion. Using browse it is shown well, however with message “This document is not UTF8. It was detected as ISO-8859-1 (Latin 1) and converted to UTF8 for display.”.

Is there any chance / plan that this “autoconversion” feature could find it’s way to Diffusion?

Thanks!