DomainException when trying to remove an DifferentialRevision

phabricator d32c3f8d7d65 Fri, Jul 17
arcanist 2565cc7b4d1d Sat, Jul 11

Other Version Information

Binary Version Path
php 7.4.8 fpm-fcgi
diff 3.7 /usr/bin/diff
git 2.20.1 /usr/bin/git
hg Not Available
pygmentize 2.3.1 /usr/bin/pygmentize
svn Not Available

When i try to destroy any revision:

Destroying objects...
Destroying DifferentialRevision D12824...
[2020-07-22 14:18:07] EXCEPTION: (DomainException) Attempting to iterate an object (of class DifferentialViewStateQuery) which is not iterable. at [<arcanist>/src/object/Phobject.php:57]
arcanist(head=stable, ref.stable=2565cc7b4d1d), phabricator(head=stable, ref.stable=d32c3f8d7d65)
  #0 Phobject::throwOnAttemptedIteration called at [<arcanist>/src/object/Phobject.php:49]
  #1 Phobject::rewind called at [<phabricator>/src/applications/differential/storage/DifferentialDiff.php:743]
  #2 PhabricatorDestructionEngine::destroyObject called at [<phabricator>/src/applications/differential/storage/DifferentialRevision.php:1022]
  #3 DifferentialRevision::destroyObjectPermanently called at [<phabricator>/src/applications/system/engine/PhabricatorDestructionEngine.php:76]
  #4 PhabricatorDestructionEngine::destroyObject called at [<phabricator>/src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php:159]
  #5 PhabricatorSystemRemoveDestroyWorkflow::execute called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:492]
  #6 PhutilArgumentParser::parseWorkflowsFull called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:377]
  #7 PhutilArgumentParser::parseWorkflows called at [<phabricator>/scripts/setup/manage_remove.php:21]
PHP Fatal error:  Uncaught Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction(). in /opt/app/phabricator/src/infrastructure/storage/connection/AphrontDatabaseTransactionState.php:78
Stack trace:
#0 [internal function]: AphrontDatabaseTransactionState->__destruct()
#1 {main}
  thrown in /opt/app/phabricator/src/infrastructure/storage/connection/AphrontDatabaseTransactionState.php on line 78

Fatal error: Uncaught Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction(). in /opt/app/phabricator/src/infrastructure/storage/connection/AphrontDatabaseTransactionState.php:78
Stack trace:
#0 [internal function]: AphrontDatabaseTransactionState->__destruct()
#1 {main}
  thrown in /opt/app/phabricator/src/infrastructure/storage/connection/AphrontDatabaseTransactionState.php on line 78

Thanks for the report!

I think this should be fixed by http://secure.phabricator.com/D21421, which is now in master and stable.

Let me know if you’re still seeing issues after upgrading.

1 Like

It’s working like charm! Thanks.