Error on project creation or edition with php7.3


#1

Observed Behavior:
After setup phabricator with php 7.3 when I try to create or edit Project, the following exception appears:
Error while loading file “/home/phabricator/phabricator/src/applications/project/editor/PhabricatorProjectTransactionEditor.php”: “continue” targeting switch is equivalent to “break”. Did you mean to use “continue 2”?

Expected Behavior:
The Project edition/creation form will be displayed

Phabricator Version:
stable branch, precisely commit 61a5a4811540e6b8c0a16fb7e9199af7b38bcbbd

Reproduction Steps:
Set up phabricator with php7.3
Go to project -> create new project (or go directly to /project/edit/form/default/)


#2

Thanks for the report, this is fixed in https://secure.phabricator.com/D19925.


#3

Thanks, now I got the next one:

Error while loading file "/home/phabricator/phabricator/src/applications/phriction/editor/PhrictionTransactionEditor.php": "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

when I try to display phrinction main page (url path is only /w/)

It seems to be very similar fix.


#4

https://secure.phabricator.com/D19931 adds a static analyzer rule to detect and correct these.

And, of course, there was only one left: the one you reported above. https://secure.phabricator.com/D19932 fixes it.


#5