Exception in bin/celerity map

#1

Observed Behavior:
When doing phabricator/bin/celerity map a exception is thrown by rsrc/libs/layout.js

./bin/celerity map Rebuilding resource source "phabricator" (CelerityPhabricatorResources)... Found 133 binary resources. [2019-04-28 16:15:31] EXCEPTION: (Exception) Resource "rsrc/libs/layout.js" does not have a header doc comment. Encode dependency data in a header docblock. at [/src/applications/celerity/CelerityResourceMapGenerator.php:226] arcanist(head=master, ref.master=9830c9316d38), phabricator(head=stable, ref.master=c0a4d1de13a8, ref.stable=edda40aa3b93), phutil(head=master, ref.master=639e4b9cae28) #0 CelerityResourceMapGenerator::getProvidesAndRequires(string, string) called at [/src/applications/celerity/CelerityResourceMapGenerator.php:192] #1 CelerityResourceMapGenerator::rebuildTextResources(CelerityPhabricatorResources, CelerityResourceTransformer) called at [/src/applications/celerity/CelerityResourceMapGenerator.php:54] #2 CelerityResourceMapGenerator::generate() called at [/src/applications/celerity/management/CelerityManagementMapWorkflow.php:47] #3 CelerityManagementMapWorkflow::rebuildResources(CelerityPhabricatorResources) called at [/src/applications/celerity/management/CelerityManagementMapWorkflow.php:24] #4 CelerityManagementMapWorkflow::execute(PhutilArgumentParser) called at [/src/parser/argument/PhutilArgumentParser.php:457] #5 PhutilArgumentParser::parseWorkflowsFull(array) called at [/src/parser/argument/PhutilArgumentParser.php:349] #6 PhutilArgumentParser::parseWorkflows(array) called at [/scripts/setup/manage_celerity.php:21]

Expected Behavior:
When doing phabricator/bin/celerity map the celerity map should be build without a exception

Phabricator Version:
edda40aa3b931ed064c52536af5b65fd6611e841 (Tue, Apr 23) (branched from 02cfcfa0796993e078c8cb632a9df39ef7227e46 on origin)

Reproduction Steps:
Run phabricator/bin/celerity map on the stable branch

#2

I can’t reproduce this.

There is no rsrc/libs/layout.js file in the upstream. This is almost certainly a problem with an extension or custom code.

#3

Hey @epriestley,

sorry for the false bug report. It was/is indeed a problem with a local install. I should have checked the upstream before reporting. Sorry!

closed #4