Exploring diff history do not show changes between diffs properly

Reproduction Instructions

  1. Work on some code, commit, and proceed to submit a diff using arc diff .
  2. Figure out something is wrong with the code, amend your commit and update the diff running are diff again.

Now move to phabricator UI and go to the diff in question.
3. Click on the “history” tab in the “Revision Contents” section of the page.
You should see here the two updates that you made using arc diff + the base code without changes.
4. Select from Diff 1 to Diff 2 and click “Show Diff”

Expected: the changes between Diff 1 and Diff 2 are displayed.
What I get instead: the file changed are displayed, but not the code changes.

You can see a demonstration of this here: https://reviews.bitcoinabc.org/D5945?vs=19391&id=19398

Phabricator/Arcanist Version
phabricator: 462a4784325c
arcanist: 31c6b56b67b0

I’m happy to provide more details as necessary. Thanks for everything.

Thanks! This was introduced by recent changes in https://secure.phabricator.com/T13523 aimed at improving intradiff rendering of images. I believe I’ve fixed it in https://secure.phabricator.com/D21210, which is now in master and stable.


This is indeed fixed. Thanks a lot!