[FIXED]Arcanist arc land did not merge into master by default with git


#1

[EDIT] after more test it works great now! weird.

Hi,

It seems arc land command is bugged, because when I run it with the name of the current branch I want to merge into master like that

$ arc land feature_branch_name

the commit is pushed on the feature branch. But the feature branch is not merged into master and closed as it should do.

I have to precise this command arg:

$ arc land feature_branch_name --onto master

This is not normal because like we can read running arc help land

      A target branch is selected by examining these sources in order:

        - the --onto flag;
        - the upstream of the current branch, recursively (Git only);
        - the arc.land.onto.default configuration setting;
        - or by falling back to a standard default:
          - "master" in Git;
          - "default" in Mercurial.

–onto master
Land feature branch onto a branch other than the default
(‘master’ in git, ‘default’ in hg). You can change the default
by setting ‘arc.land.onto.default’ with arc set-config or for
the entire project in .arcconfig.

My default remote branch is origin/master
Locally master

I tried both the arc set-config arc.land.onto.default master and set it in the .arcconfig. Change nothing. I still to have to precise --onto master arg

I missed something ?

[EDIT] after more test it works great now! weird.


#2
    A target branch is selected by examining these sources in order:

        - the --onto flag;
        - the upstream of the current branch, recursively (Git only);
        ...

“The upstream of the current branch” is the “feature branch” you have on the server. That’s exactly the behavior you describe.