The title is very broad, but I honestly cannot come up with a decent question, so please bear with me.
Recently we have introduced a code ownership automation via Packages. Whenever someone posts a revision, Phabricator will summon several teams as reviewers, depending on which files are affected. As I have email notifications turned on, I will get emails saying that someone posted a revision I should look at. So far so good.
We have several MLOC codebase mostly in C++ that is unfortunately rather tightly coupled, so it is frequent that someone changes things in the area of responsibility of several teams at once. Thus we introduced a policy that a team should be strictly responsible for the files in their area, but is free skip the rest of revision. E.g., the revision changes code about video analytics and code about video archive storage – the archive guys should thoroughly check the archive stuff, but they might very likely get lost in the analytics stuff, so they are free to not review. And vice versa
My team specifically is responsible for automation tests, Jenkins integration, CMake build ecosystem etc. and in our case we can simply drown in the amount of notification flooding us. Example: someone posts a revision adding new source files to be built in
CMakeLists build script, adding new Jenkins test, and changing 10 more files adding some business logic. We review the build and test changes – and they are basically set in stone for the rest of revision. Well, maybe there will be more files to be built added to the list of files.
However other people notice some flaws in the business logic code itself, so the revision goes into 20 more “declined”, “updated”, “accepted”, “changes planned”, “review requested” iterations. All the while the stuff we reviewed stays unchanged, but we recieve a ton of email notifications about changes and discussions we are not even interested in. It honestly drives me nuts and makes me want to turn off notifications altogether – which would hinder my reactions to people reviewing my revisions and replying to my comments in theirs.
So… can we do something to make our life as reviewers easier? Is there something fundamentally wrong with our approach, since I notice that Phabricator sometimes relies on some unusual (for us) workflows? I think simply having more options to filter notifications in
Email settings would help buuuut I think it would require a lot more options to really make difference.