I appear to still be having this or a very similar issue.
Given a Herald Rule:
When any of these conditions are met: - Affected files contains foo.ext - Affected files contains bar.ext - Affected files contains baz.ext - Affected files contains qwerty.ext Take these actions the first time this rule matches: - Send an email to: user1, user2, user3
(I also tried w/ “every time this rule matches”, which is what the users actually want for their rule, but I figured maybe it didn’t work properly.)
I create a Revision via normal
arc diff command.
The following “actions” are listed on the Revision:
Tue, Jul 2, 19:10 - mribau created this revision. Tue, Jul 2, 19:10 - Owners added a reviewer: O4: REDACTED owned. Tue, Jul 2, 19:10 - Herald added a reviewer: REDACTED. · View Herald Transcript - Herald added projects: REDACTED. · View Herald Transcript Tue, Jul 2, 19:10 - mribau requested review of this revision. Tue, Jul 2, 19:10 - Harbormaster completed remote builds in B56785: Diff 115987.
When viewing the Herald Transcript for the rule above, the following is shown:
H21 PFRs: Email Users - Logging REDACTED Conditions Forbidden Object state prevented rule evaluation. Action: Send an email to Forbidden This revision is still an unsubmitted draft, so mail will not be sent yet.
Based on the linked Task in prior comments, it looks like Herald is supposed to run a second time and actually process the rule? It doesn’t seem to be happening for me. Did I misunderstand how this is supposed to be working?
phabricator 5cf820bd35bf859c85e588f6fee2471ba06083e8 (Tue, Jun 18) (branched from 683647f1fb9091b8928056d068be7bb954c127c9 on upstream) arcanist 36a397de12d07ad2093f2299c418a178502d1747 (Thu, Jun 13) (branched from 2234c8cacc21ce61c9c10e8e5918b6a63cc38fc8 on upstream) phutil 1fcc3a2d3799581453584c90d621329a7ed5c00d (Tue, Jun 11) (branched from e4f8b70e73faff0edeb3a310c0ff1d10b4b54949 on upstream)