[invalid] Passphrase.query does not return secrets

#1

Observed Behavior:
Calling passphrase.query in conduit returns an empty material list for all credential types.

Expected Behavior:
The credential secret should be returned. (per PassphraseQueryConduitAPIMethod.php)

Phabricator Version:

  • phabricator (Sun, Mar 24) (branched from aae7bdbbdd5646457b6014210e6442ac665fe6e3 on origin)
  • arcanist (Fri, Mar 8) (branched from 9830c9316d38988b2dc283ac1a124b73bc8e6c5f on origin)
  • phutil (Sat, Mar 16) (branched from 34b68955748bb1b2fcbfa86ad69c0e4856d21906 on origin)
  • libcore (Mon, Mar 4)
  • services (Sat, Mar 23) (branched from 832743e4894d6efdba6203de0bb35e711791cbce on origin)

Reproduction Steps:

  • Launch a Phacility Test Instance
  • Create a new Passphrase credential
  • Set “Allow Conduit Access” to True
  • Call passphrase.query method to retrieve the secret:
curl https://test-3xtug55vkelh.phacility.com/api/passphrase.query \
  -d api.token=${API_TOKEN} \
  -d ids[0]=2
  • See empty list in response
{
  "data": {
    "PHID-CDTL-gedx6nkwh2gj4lspyvpt": {
      "id": "2",
      "phid": "PHID-CDTL-gedx6nkwh2gj4lspyvpt",
      "type": "ssh-key-text",
      "name": "test private key",
      "description": "",
      "uri": "https://test-3xtug55vkelh.phacility.com/K2",
      "monogram": "K2",
      "username": "test",
      "material": []
    }
  },
  "cursor": {
    "limit": 100,
    "after": null,
    "before": null
  }
}

This applies to all Passphrase credential types.

0 Likes

#2

Nevermind, I’m just an idiot and wasn’t passing in needSecret / needPublicKey booleans. Sorry for that.

0 Likes

closed #3
0 Likes