Lint workflow changes from

Arcanist
#1

I was encountering some issues using arcanist on Ubuntu 20.04, and per this topic, I switched to using arcanist from github directly. However, there are a few workflow changes from the version Ubuntu provides:

  • If the only lint issues with a file are autofix issues, the linter with automatically apply the changes without a prompt when running arc lint, or will automatically apply the changes but ask whether or not to amend them to HEAD when running arc diff. Previously, I was always prompted for Y/n when running arc lint, regardless of whether or not the only issues are autofix issues, and arc diff didn’t make changes if you didn’t ask it to.
  • arc diff no longer prompts for a lint excuse when creating/updating a diff

Is there a way to restore the previous workflow?

1 Like
#2

Is there a way to restore the previous workflow?

No.

  • arc diff no longer prompts for a lint excuse when creating/updating a diff

This was intentionally removed.

If the only lint issues with a file are autofix issues…

This is a bug. I plan to restore the old behavior.

#3

This is a bug. I plan to restore the old behavior.

Is there a bug report I can follow?

#4

I’m seeing this issue, too.

Running arc lint will now automatically apply auto-fixes, rather than prompting for confirmation.

From @epriestley reply, I can’t tell whether this behavior change was intended or accidental, and whether it will be addressed.

I can new see this behavior in both stable and master.

arcanist e95afd1d005c389ef6215a809f6f94007826467c (19 Feb 2021)

PHP 7.4.12 (cli) (built: Oct 27 2020 17:18:47) ( ZTS Visual C++ 2017 x64 )