Partial file uploads throw UNRECOVERABLE FATAL ERROR


Observed Behavior:
After a file upload fails to complete, a file with the attribute Partial is created. Clicking this file in the Files application throws the following error.


Call to a member function loadFileData() on a non-object


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

Expected Behavior:
A page is loaded where the details of partially-uploaded file can be viewed, or the file can be deleted.

Phabricator Version:
phabricator cc69bed52fb9ed8beef136f7dfef555a1e91331f (Sat, Jun 23) (branched from cac3dc4983c3671ba4ec841aac8efac10744a80c on origin)
arcanist c1b1e69b8fbf432d27277ac77b7369137576ca15 (Fri, Jun 8) (branched from df7313bdf2a34d03667fe20c850a10ad3878e27d on origin)
phutil 4206849bb05b60f536a1c78e33adee68dac67aa9 (Fri, Jun 8)

Reproduction Steps:

  1. Start an upload of a larger file that requires chunking.
  2. While the file is uploading, navigate to a different page to force the upload to fail.
  3. Navigate to the Files application and click the link to the partially-uploaded file.
  4. The fatal error is displayed.


I’ve seen this too. I had a broken file upload and trying to navigate to it gave this exact error.