Phabricator not properly sending SendGrid Emails

Bug
#1

When using a sendgrid mailer, it fails with a HTTP 400, and responds:

{
  "errors": [
    {
      "message": "The from email does not contain a valid address.",
      "field": "from.email",
      "help": "http://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.from"
    }
  ]
}

When viewing from the cli, it says that there is no “from” property.

Reproduction Instructions

  1. Properly setup a mailer with the sendgrid type.
  2. Try to send any email (I have tried verification email and a manual test email)
  3. It will be “queued,” however it will get a 400 error from sendgrid.

Phabricator/Arcanist Version
Phabricator: 86ad69863930
Arcanist: ac54d61d7af2

#2

Sorry, I’m stupid.
I forgot to set metamta.default-address properly.

#3