Remarkup named web links no longer allow name to be monospace

Remarkup seems to no longer allow for monospace text to be used in the name of a named link.

A named web link like:

[[ https://google.ca | `google` ]]

Used to produce a hyperlink like this (except actually a link):

google

Now however, only the url (https://google.ca) is rendered as a hyperlink and the rest of the markup is still shown. Thankfully this form seems to be rendered with Remarkup so the bad behaviour is also reproduced here:

[[ https://google.ca | google ]]

I’m not certain which phabricator/etc… version we were running prior to this (it had been a while since I’d updated) but it was stable branch from November or December 2019.


Phabricator/Arcanist Version

Phabricator Version Information

Library Version Date Branchpoint
phabricator ff6f24db2bc0 Wed, Feb 12 2327578adc94
arcanist 729100955129 Thu, Jan 30 21a1828ea06c
phutil 034cf7cc3994 Thu, Jan 30 cc2a3dbf5903

Other Version Information

Binary Version Path
php 7.2.24-0ubuntu0.18.04.3 fpm-fcgi
diff 3.6 /usr/bin/diff
git 2.17.1 /usr/bin/git
hg Not Available
pygmentize 2.2.0 /usr/bin/pygmentize
svn 1.9.7 /usr/bin/svn
1 Like

This was never an intended behavior (and no other variation has ever worked, e.g. [[ X | **Y** ]] has never produced a bold link), and was changed to fix a security vulnerability:

https://secure.phabricator.com/D20937

I may be able to restore the old behavior without restoring the security vulnerability, but it’s difficult given how the parser works.

Thanks.

Clearly not a huge issue, I’d just assumed it was intentional to render it that way. I mostly just liked the way it looked when I added links to branches in our code review system. :slight_smile:

This is breaking a bunch of our markup, for what it’s worth.

I confirmed that none of the following work:

[`foo`](https://www.example.com)
[[ https://www.example.com | `foo` ]]
`[foo](https://www.example.com)`

This also seems to have broken many comments, project descriptions, and RFCs in Wikimedia’s Phabricator instance. I’ve encountered at least a dozen in the past two days.

For example, at https://phabricator.wikimedia.org/T225871: