Removing tags or subscribers from a Maniphest modal causes the modal to close

Reproduction Instructions

  • Go to a project workboard
  • Open a Maniphest modal by clicking the pencil icon on a task card
  • Try to remove a tag or subscriber
  • See that the modal closes, instead of the tag/subscriber being removed

Phabricator/Arcanist Version
phabricator 2d2626d73f0b50a6f10c06a82c0db7f9640e9af3
arcanist feb5f4d42c4fe0001e76428e80d5e88262308802
libphutil b675a06bf7419ff3b64448cb310e7557530446db

Thanks. This should be fixed by https://secure.phabricator.com/D20623.

1 Like

Is this console error unexpected after applying the fix? It did fix the bug, but in the console that I happened to have open to try to identify the original issue, I noticed this now happens anytime I close a modal (confirmed identical stacktrace both from closing the New Issue modal and the Edit Comment modal on a task).

Uncaught TypeError: Cannot read property ‘getCloseHandler’ of undefined
at Function._pop (core.pkg.js:412)
at Object._onbutton [as _callback] (core.pkg.js:417)
at Function.pass (core.pkg.js:164)
at Function._dispatchProxy (core.pkg.js:159)
at Function.dispatch (core.pkg.js:142)
at HTMLHtmlElement.JX.__rawEventQueue (init.js:19)

Happy to provide any other info that may be available to me here.

The Javascript console error you describe should be fixed by https://secure.phabricator.com/D20640.

1 Like