Supporting new Security Key SSH keys

I’ve been trying out the security key support in SSH that has been added recently. I wanted to try it out with Phabricator, so I looked through the code and found that the recognized keys are set in the phabricator repo in the file:

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

I added the following key types to recognized_keys:

sk-ssh-ed25519@openssh.com
sk-ecdsa-sha2-nistp256@openssh.com

After that, my SSH key works properly when running git commands. Is this something that could be added? Or is there additional logic elsewhere on the SSH key type that this might be messing up?

From https://secure.phabricator.com/D11930#116481, that’s probably fine.