"UNSAFE: Raw string.." warnings while importing git commits


#1

Observed Behavior:
Noticed the following lines in my PhabricatorTaskmasterDaemon logs while importing a large git repository:

Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:39 +0000] [2018-12-11 15:59:12] PHLOG: 'UNSAFE: Raw string ("(52, 5058, 41126, null, null, 1, 7, 1, 1424104571)") passed to query ("INSERT INTO %s
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:39 +0000]           (repositoryID, pathID, commitID, targetPathID, targetCommitID,
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:39 +0000]             changeType, fileType, isDirect, commitSequence)
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:39 +0000]           VALUES %LQ") subclause for "%LQ" conversion. Subclause conversions should be passed a list of PhutilQueryString objects.' at [/opt/libphutil/src/xsprintf/qsprintf.php:413]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000] arcanist(head=stable, ref.stable=45a8d22c74a6), harbormaster-gocd-buildstep(), phabricator(head=stable, ref.stable=237a2a190984), phutil(head=stable, ref.stable=414a4c6abb1b)
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #0 phlog(string) called at [<phutil>/src/xsprintf/qsprintf.php:413]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #1 qsprintf_check_scalar_type(string, string, string) called at [<phutil>/src/xsprintf/qsprintf.php:389]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #2 qsprintf_check_type(array, string, string) called at [<phutil>/src/xsprintf/qsprintf.php:155]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #3 xsprintf_query(array, string, integer, array, integer) called at [<phutil>/src/xsprintf/xsprintf.php:70]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #4 xsprintf(string, array, array) called at [<phutil>/src/xsprintf/PhutilQueryString.php:36]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #5 PhutilQueryString::renderString(boolean) called at [<phutil>/src/xsprintf/PhutilQueryString.php:26]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:40 +0000]   #6 PhutilQueryString::getMaskedString() called at [<phutil>/src/xsprintf/PhutilQueryString.php:14]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #7 PhutilQueryString::__construct(AphrontMySQLiDatabaseConnection, array) called at [<phutil>/src/xsprintf/qsprintf.php:78]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #8 qsprintf(AphrontMySQLiDatabaseConnection, string, string, array) called at [<phutil>/src/xsprintf/queryfx.php:5]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #9 queryfx(AphrontMySQLiDatabaseConnection, string, string, array) called at [<phabricator>/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php:156]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #10 PhabricatorRepositoryCommitChangeParserWorker::writeCommitChanges(PhabricatorRepository, PhabricatorRepositoryCommit, array) called at [<phabricator>/src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php:38]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #11 PhabricatorRepositoryCommitChangeParserWorker::parseCommit(PhabricatorRepository, PhabricatorRepositoryCommit) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:51]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #12 PhabricatorRepositoryCommitParserWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:123]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:41 +0000]   #13 PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:171]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:42 +0000]   #14 PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:22]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:42 +0000]   #15 PhabricatorTaskmasterDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:219]
Daemon 82855 STDE [Tue, 11 Dec 2018 16:09:42 +0000]   #16 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:131]

This is repeated many times.

Expected Behavior:
There should be no such warnings logged according to T13217

Phabricator Version:
phabricator 237a2a190984cb359f8de62cdf023cfcff8d80e6 (Mon, Dec 10)
arcanist 45a8d22c74a62624e69f5cd6ce901c9ab2658904 (Mon, Nov 12)
phutil 414a4c6abb1b574f576d72432e8ceb4b9b3cbf91 (Mon, Dec 10)

Reproduction Steps:
I believe these lines get logged when importing new git commits.


#2

Thanks, see https://secure.phabricator.com/D19869.


#3