"UNSAFE: Raw string.." warnings


#1

Observed Behavior:
After upgrading to the latest stable Phabricator code, my Apache web server error log started to get lines like these:

[Tue Dec 04 12:29:40.523932 2018] [php7:notice] [pid 566] [client 172.17.42.1:60126] [2018-12-04 12:29:40] PHLOG: 'UNSAFE: Raw string ("(SELECT `commit`.* FROM `repository_commit` `commit`  
WHERE ((commit.authorPHID IN ('PHID-USER-ko2swj6k2yqgu5s3oreu', 'PHID-PROJ-mvblbi2rotka33hhwu6p', 'PHID-PROJ-lxlmpgipd5egfhwcbng7', 'PHID-PROJ-3v6fsdn7lvgj4qsajvtk', 'PHID-PROJ-vywpoztaa4dvxm4jhkua')) AND (commit.auditStatus IN ('needs-audit')))   ORDER BY `commit`.`epoch` DESC, `commit`.`id` DESC LIMIT 1001) UNION DISTINCT (SELECT `commit`.* FROM `repository_commit` `commit` JOIN `repository_auditrequest` auditor ON commit.phid = auditor.commitPHID WHERE ((auditor.auditorPHID IN ('PHID-USER-ko2swj6k2yqgu5s3oreu', 'PHID-PROJ-mvblbi2rotka33hhwu6p', 'PHID-PROJ-lxlmpgipd5egfhwcbng7', 'PHID-PROJ-3v6fsdn7lvgj4qsajvtk', 'PHID-PROJ-vywpoztaa4dvxm4jhkua')) AND (commit.auditStatus IN ('needs-audit'))) GROUP BY `commit`.phid  ORDER BY `commit`.`epoch` DESC, `commit`.`id` DESC LIMIT 1001)") passed to query ("%Q %Q %Q") for "%Q" conversion. %Q should be passed a query string.' at [/opt/libphutil/src/xsprintf/qsprintf.php:432]
[Tue Dec 04 12:30:01.354083 2018] [php7:notice] [pid 95] [client 172.17.42.1:60768] [2018-12-04 12:30:01] PHLOG: 'UNSAFE: Raw string ("(SELECT `commit`.* FROM `repository_commit` `commit`  WHERE ((commit.authorPHID IN ('PHID-USER-ko2swj6k2yqgu5s3oreu', 'PHID-PROJ-mvblbi2rotka33hhwu6p', 'PHID-PROJ-lxlmpgipd5egfhwcbng7', 'PHID-PROJ-3v6fsdn7lvgj4qsajvtk', 'PHID-PROJ-vywpoztaa4dvxm
4jhkua')) AND (commit.auditStatus IN ('needs-audit', 'concern-raised', 'partially-audited', 'needs-verification')) AND ((commit.importStatus & 2048) = 0))   ORDER BY `commit`.`epoch` DESC, `commit`.`id` DESC LIMIT 1001) UNION DISTINCT (SELECT `commit`.* FROM `repository_commit` `commit` JOIN `repository_auditrequest` auditor ON commit.phid = auditor.commitPHID WHERE ((auditor.auditorPHID IN ('PHID-USER-ko2swj6k2yqgu5s3oreu', 'PHID-PROJ-mvblbi2rotka33hhwu6p', 'PHID-PROJ-lxlmpgipd5egfhwcbng7', 'PHID-PROJ-3v6fsdn7lvgj4qsajvtk', 'PHID-PROJ-vywpoztaa4dvxm4jhkua')) AND 
(commit.auditStatus IN ('needs-audit', 'concern-raised', 'partially-audited', 'needs-verification')) AND ((commit.importStatus & 2048) = 0)) GROUP BY `commit`.phid  ORDER BY `commit`.`epoc...' at [/opt/libphutil/src/xsprintf/qsprintf.php:432]

Expected Behavior:
There should be no such warnings logged according to T13217.

Phabricator Version:
phabricator 8ef2f4086ee3479853f045d0fa1457bebd833bbd (Mon, Dec 3)
arcanist 45a8d22c74a62624e69f5cd6ce901c9ab2658904 (Mon, Nov 12)
phutil 2a2d4fce881ea48974e7356ca4cf3d33105998f0 (Mon, Dec 3)

Reproduction Steps:
I believe these lines get logged when auditors review commits and try to accept or reject them.


#2

This should be fixed by https://secure.phabricator.com/D19845.