Why accepted revision by project and package still requires review from the user?


#1

Hi there,

I want to understand if following situation is expected and what is motivation behind this if yes. Test case:

  • User creates differential revision
  • Differential revision is accepted by project and/or project package but not user. It is possible uncheck the checkbox "Accept as " when accepting the revision.

Then:

  • Revision status is still “needs review”.
  • arc land still requires revision to be reviewed.

Screenshot%20from%202018-10-30%2012-30-36

So my question here:

  • Why differential revision is treated as unreviewed if it was accepted by project and/or owners package?

Thanks!


#2

This is expected. See https://secure.phabricator.com/T731.

Revisions must have at least one “accept” from a human reviewer.